Product-card-component

Community feedback

• 

  Dot-theduck•70

  @Dot-theduckPosted over 1 year ago

  I have some suggestions about your code that might interest you.

  For the alt attribute of the logo, use the company name as the alt description. The words "images" or "logo" are not necessary. The social media icons should be links (<a>) and contain the <i> element inside. Use rem or em instead of pixels for font-size, this way the font size will adapt based on the user's browser settings. Add two dots instead of one to display the image correctly, as the CSS file is inside a folder. For example: background-image: url(../images/bg-desktop.svg); I hope you find it useful!

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
  • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
  • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the component wrapper <div> element with the proper semantic element <main> element in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0