Product-Card

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello There👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  HTML 🏷️:

  • This solution generates accessibility error reports due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the <div class="card"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  HEADINGS ⚠️:

  ---

  • And, this solution has also generated accessibility error report due to lack of level-one heading <h1>

  ---

  • Every site must want at least one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Barry Thatcher•70

  @Bazza-08Posted over 1 year ago

  @0xAbdulKhalid You're awesome! Thanks for the input! :)

  0
• 

  Barry Thatcher•70

  @Bazza-08Posted over 1 year ago

  In the solution it is showing that my image is not inline with the bottom of the card container? On netlify and other browsers it displays correctly. Is there something I need to change in the code?

  0

  ---

  

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  @Bazza-08 the reason is related to the fixed height you have set up. To replicate what's happening during screenshot, you can try to increase your font-size for heading from 3em to 4em. The effect will be visible and this should give you an idea for you about how to handle. Basically avoid fixed heights. Screenshots are taken on a Firefox Browser with 1440px width.

  It looks like you have imported fonts correctly. But just not applied them all correctly, e.g. the new price font should be the other one you have imported.

  Hope you find this feedback helpful!

  Marked as helpful

  0

  

  Barry Thatcher•70

  @Bazza-08Posted over 1 year ago

  @visualdenniss Thank you!

  0