Design comparison
SolutionDesign
Community feedback
- @moadavouPosted 6 months ago
Great work on completing this project! Here is some feedback, as per your request in the Discord group.
HTML
- You have used the
<picture>
wrong. I can see that this is reoccurring in your projects. I recommend you to look up how to use it.
- You need to add a
<span>
with the visually hidden class containing text indicating the old price. Otherwise, screen readers read the new and the old prices without any clarification as to what is what.
CSS
- Use
em
orrem
in media queries. If you usepx
the breakpoint will not change with user settings regarding fonts.
1 - You have used the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord