Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product Review Using HTML and CSS

@victorad375

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I'll be open to constructive criticism.

Community feedback

@VictorBrito13

Posted

Hi I checkout your and I would made some changes:

To the ever class I would use the grid to make the column layout and justify the content.

Also I would remove the margin-top to the img and the padding-right to the im class because it broke the layout

Finally add a media-query to improve the mobile layout.

Some resource: grid: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Grid_Layout

media queries: https://developer.mozilla.org/en-US/docs/Web/CSS/Media_Queries/Using_media_queries

box model: https://www.w3schools.com/css/css_boxmodel.asp

PD: I also create a pull request to you repository

0

@victorad375

Posted

Thanks @VictorBrito13

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord