Product review page

Community feedback

• 

  P

  Jake Godsall•1,390

  @jakegodsallPosted about 2 years ago

  This could be achieved by creating an outer div for the two prices, and using flexbox display property as follows:

  <div class="prices">
    <h1 class="price"> $149.99</h1>
    <h5 class="price"> $169.99</h5>
  </div>
  

  .prices {
    display: flex;
    align-items: center;
  }
  

  If you would like to learn more about flexbox, I would highly recommend Flexbox zombies https://geddski.teachable.com/p/flexbox-zombies I learned everything I know about flexbox from playing this game.

  Hope this helps

  Marked as helpful

  1

  ---

  

  Mohit rakh•30

  @mohitrakhPosted about 2 years ago

  @jakegodsall Thank you so much it worked.

  0
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hi Mohit, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great start and great first solution! You’ve done really good work here putting everything together, I’ve some suggestions you can consider applying to your code:

  1.Use <main> instead of <div> to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.

  2.Use the tag <picture>to wrap the product image inside the html instead of using it as <img> or background-image (with the css). Using <picture> you wrap both images (desktop and mobile) and have more control over it, since you can set in the html when the images changes setting the screen size for each image.ote that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image.

  3.Fix the component responsiveness, its not working yet and this is due the fixed width you've applied to the container. The difference between width and max-width is that the first(width) is fixed and the second(max-width) is flexible and make the element shrink when the screen starts to scale down. So if you want a responsive block element, never use width choose or min-width or max-width.

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1