Product review card using HTML and CSS

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  • Rename the propic.html file to index.html.

    When a user types a URL into their browser, the browser sends a request for the resource at that URL. later, the server will look for a default file to serve in that directory. By convention, the default file is named "index.html".

    Naming the main file of a website "index.html" allows for a cleaner and more intuitive URL structure for the website. For example, if the main file was named "propic.html", the URL to access the page would be https://wicaksono37.github.io/product_review_card/propic.html instead of https://wicaksono37.github.io/product_review_card/ which is less clear and less aesthetically pleasing.

  • Upload the images to the GitHub repository, otherwise it won't show up in your solution

  HTML 📄:

  • Use semantic elements such as <main> and <footer> to improve accessibility and organization of your page.

  • Avoid using uppercase text in your HTML because screen readers will read it letter by letter. You can use the text-transform property to transform the text to uppercase in CSS.

  • Not all images should have alt text. The cart-icon is a decorative image, it does not add any information to the page. You should use an empty alt attribute instead of a descriptive one. You can read more about this here 📘.

    If you want to learn more about the alt attribute, you can read this article. 📘.

  I hope you find it useful! 😄

  Happy coding!

  Marked as helpful

  1

  ---

  

  wisnu_wicaksono•240

  @wicaksono37Posted almost 2 years ago

  @MelvinAguilar hello,,, big thanks for your advice. I'm still newbie at html, css and github. I still don't understand about github, I will do as your advice. Again big thanks !

  0