Product Review Card (Raw HTML and CSS)

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the <div id="productReviewHolder"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  Furk•600

  @doganfurkanPosted over 1 year ago

  You should start using @media in your CSS to build responsive websites. Here is w3schools link for @media for you to start learning: @media rule. Using media queries for min-width (or max-width) of screen gives you the freedom to change elements for mobile and desktop solutions.

  Other than responsivity, I think you can use the flex-box better. You have #productReviewHolder, and it is a flexbox, but you set a width and height for it. Why? It is flexible unless you set width and height for it. Give it a "max-width" and let the height be flexible.

  I also recently did this challenge. If you want to have a look at my solution and see the way i handled it, here is the link: Responsive Product Preview Card

  Keep up the hard work!

  0
• 

  Tine•40

  @TineMSPetersenPosted over 1 year ago

  For responsive, look into media queries: https://www.w3schools.com/Css/css3_mediaqueries_ex.asp It's usually easier to design the mobile version first, then adjust the layout with media queries for desktop afterwards, but it can for sure be done the other way around, too, so don't worry! :)

  Also avoiding giving your containers a fixed height should help fix the issue with elements bleeding outside of the box

  Good luck, it looks great so far!

  0