Design comparison
Community feedback
- @NehalSahu8055Posted over 1 year ago
Hello Coder 👋.
Congratulations on successfully completing the challenge! 🎉
Few suggestions regarding design.
➨ Replace
height:100vh
withmin-height:100vh
to properly center the card.body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
-
Always follow
heading in increasing order
h1, h2, h3, h4... you use h4 before h1 here. -
It would be better if you use source media for switching to screen sizes(mobile or desktop) for image.
<picture> <source media="(min-width:800px)" srcset="yourimage.jpg"> <img src="yourimage.jpg" alt="description"> </picture>
-
For
non-decorative images
give meaningful and descriptive alt likealt= "Gabrielle Chanel Perfume bottle surrounded by leaves."
. -
Use
responsive units(rem, em, %)
from next project. Explore respective use cases on google. -
Replace
width
withmax-width
to make your card more responsive.
link.
I hope you find this helpful.
Happy coding😄
Marked as helpful1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord