product review card html & css challenge

Community feedback

• 

  Erel Ropeta•385

  @ereljapcoPosted over 2 years ago

  Hey, Shay! Nice to see your finished solution for this challenge. Just submitted mine, as well :)

  Just some few points:

  Re: accessibility

  • You could wrap the container inside the main tags and the attribution inside the footer tags.
  • For the icon tag, since its for decoration only, you could add a blank alt alt=""

  Re: styles

  • If you will use the main tags, as I suggested, you could set its height to 100vh and place your container in the center using flexbox on the main
  • You can decrease your breakpoint (i.e. the value of min-width on media query) to make your solution more responsive :)

  Marked as helpful

  0

  ---

  

  Shay•20

  @ShayinurPosted over 2 years ago

  @ereljapco thanks for the feedback Erel! I'm working on it :)

  0
• 

  faizan•2,420

  @afaiz-spacePosted over 2 years ago

  Hey @Shayinur, congratulation on completing the challenges. class .container use width: 30rem; and then object set in center. class .price use align-items: center; and remove flex-wrap property.

  0