Erel Ropeta• 385
@ereljapco
Posted
Hey, Shay! Nice to see your finished solution for this challenge. Just submitted mine, as well :)
Just some few points:
Re: accessibility
- You could wrap the
container
inside themain
tags and theattribution
inside thefooter
tags. - For the icon tag, since its for decoration only, you could add a blank alt
alt=""
Re: styles
- If you will use the
main
tags, as I suggested, you could set its height to100vh
and place yourcontainer
in the center using flexbox on themain
- You can decrease your breakpoint (i.e. the value of
min-width
on media query) to make your solution more responsive :)
Marked as helpful
0
Shay• 20
@Shayinur
Posted
@ereljapco thanks for the feedback Erel! I'm working on it :)
0