Design comparison
Solution retrospective
Following feedback, I used flex on the body to centre the content rather than margin. I also used css to populate and change the images for the first time (so that's something new learned).
What challenges did you encounter, and how did you overcome them?This went pretty smoothly.
What specific areas of your project would you like help with?Any feedback on whether my approach to marking text is correct. I think I'm using headings too and should be using span instead.
Community feedback
- @danielmrz-devPosted 5 months ago
Hello there!
Congrats on completing the challenge! ā
Your project looks great!
I have a suggestion about your code that might interest you:
š You can use the
<picture>
tag when you have different versions of the same image.Using the
<picture>
tag will help load the correct image to the user's device, saving bandwidth and improving performance.Example:
<picture> <source media="(min-width: 768px)" srcset="{desktop image path here}"> <img src="{mobile image path here}" alt="{alternative text here}"> </picture>
I hope this helps!
Other than that, excellent work!
Marked as helpful0@Shanahan914Posted 5 months ago@danielmrz-dev thanks again - will definitely use this in future.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord