
Design comparison
SolutionDesign
Solution retrospective
- How to name color variables? primary, neutral, cornflower, blue, ...?
- When to use
%
? I userem/em
in most cases andpx
for margin/padding - I put everything in
figcaption
, is that right? Because I think all of the information is about the picture, so they are all caption. - Is there too much explicit width? including
max-width
andmax-height
- Better ways to write HTML & CSS: semantics, too many div?, class usage, CSS code refactoring
Any comments are welcomed! Thanks for reading this submission
Please log in to post a comment
Log in with GitHubCommunity feedback
No feedback yet. Be the first to give feedback on devusexu's solution.
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord