
Design comparison
Community feedback
- P@gabeiPosted about 1 month ago
Hello - nice job!
There are a few things I wanted to mention about your solution:
-
On mobile devices the main container appears to be extending out of the bottom of the screen, which clips the
Add to cart
. This happens on mobile devices with a screen height less than 700px. -
You probably already know this, but you have some CSS variables initialized on the
:root
selector. You also use some SASS variables further down in your stylesheet. For consistency those could all be SASS variables, and maybe even separated into a separate stylesheet. The same can be said about the reset properties at the beginning. It might be a little neater to navigate for you if they are all separated into several files.
Happy coding!
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord