Design comparison
Solution retrospective
Very happy with how this came out .would love to hear some feedback.
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there š. Congratulations on successfully completing the challenge! š
- I have other recommendations regarding your code that I believe will be of great interest to you.
DECORATIVE SVG'S āØļø:
- The
alt
attribute is used to provide alternative text for images in HTML documents. Thealt
attribute is used by screen readers to describe the image to visually impaired users, which is essential for web accessibility.
- Now, when it comes to decorative
SVGs
, they are used purely for aesthetic purposes and do not convey any important information or functionality to the user.
- Since these images do not convey any important information or functionality, there is no need for an
alt
attribute.
- So feel free to set the
alt
attribute as""
for decorativesvg's
, becausealt=""
will be skipped by screen readers they will consider the image as decoration
Example:
<img src="images/decorative.svg" alt="">
<img src="img/icon-cart.svg" alt="Cart-icon" class="cart"> š <img src="img/icon-cart.svg" alt="Cart-icon" class="">
.
I hope you find this helpful š Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1 - @DeolabestPosted over 1 year ago
Hey @xdcron, Congratulations on completing this challenge!
Here is my feedback:
- You don't need a div for main-container when you already have the main element.
Keep doing a good job!
Marked as helpful1 - @KuraanalPosted over 1 year ago
Hey.
Instead of having a container "First-box" with 2 images inside and switching display in the css, you can use a 'Picture' tag with a sourceset and let the browser decide which one to load.
<picture class="first-box"> <source srcset="img/image-product-desktop.jpg" media="(min-width: 600px)"/> <img src="img/image-product-mobile.jpg" alt="Eau De Parfum"/> </picture>
You can find more about the picture tag here: Picture Tag info page
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord