Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product review card

@RoRajak

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I will really appreciate all your feedback for this project. what should I need to note down so that I will not repeat the mistake twice.

Community feedback

@OmprakashR

Posted

Hi, Congratulation!

You did a great job!

I have one suggestion for this.

  • update height to min-height:100vh;

as you use the hieght:90vh viewport height the full viewport size is 100vh with included address bar.

add min-height:100vh; in the body.

Help link for the viewport. https://dev.to/frehner/css-vh-dvh-lvh-svh-and-vw-units-27k4

I hope this is helpful to you.

Marked as helpful

0

@RoRajak

Posted

@OmprakashR thanks for the feedback

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord