Design comparison
SolutionDesign
Solution retrospective
Please i would really love to get your feedback on this challenge..
Community feedback
- @MelvinAguilarPosted about 1 year ago
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
CSS ๐จ:
- Avoid using all uppercase text directly in HTML; instead, use CSS's
text-transform
property to handle casing.
-
You could use the
<del>
tag to indicate the price that was before the discount. Additionally, you can use asr-only
class to describe the discount. This will help screen reader users to understand that the price was discounted.Example:
<del><span class="sr-only">Old price: </span>$169.99</del>
- The element
<div class="button">
should be a button and not a div. Since the element has a hover effect and is interactive, it's better to use a button element for accessibility.
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding!
Marked as helpful0 - Avoid using all uppercase text directly in HTML; instead, use CSS's
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord