@MelvinAguilar
Posted
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML ๐ท๏ธ:
- Wrap the page's whole main content in the
<main>
tag.
CSS ๐จ:
- To improve your approach, I'd suggest not treating the
<body>
element like any other component by setting its width. Instead, let it occupy the full width of the screen.
- Avoid using all uppercase text directly in HTML; instead, use CSS's
text-transform
property to handle casing.
- Use
min-height: 100vh
instead ofheight
. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
@CamiloZamora
Posted
@MelvinAguilar thanks for that helpful comment.
I just modified those points and works just fine.
PD: With the HTML tip I fixed all flags on the Accessibility report. Awesome!