Design comparison
SolutionDesign
Solution retrospective
Do you have any comment, tip or improvement? What framework do you recommend to start with?
Community feedback
- @MelvinAguilarPosted about 1 year ago
Hello there 👋. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML 🏷️:
- Wrap the page's whole main content in the
<main>tag.
CSS 🎨:
- To improve your approach, I'd suggest not treating the
<body>element like any other component by setting its width. Instead, let it occupy the full width of the screen.
- Avoid using all uppercase text directly in HTML; instead, use CSS's
text-transformproperty to handle casing.
- Use
min-height: 100vhinstead ofheight. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
Marked as helpful0@CamiloZamoraPosted about 1 year ago@MelvinAguilar thanks for that helpful comment.
I just modified those points and works just fine.
PD: With the HTML tip I fixed all flags on the Accessibility report. Awesome!
1 - Wrap the page's whole main content in the
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord