product preview-card component with media query

Community feedback

• 

  P

  Jeff Lang•280

  @jefflangtechPosted almost 2 years ago

  Hello!

  One way you could approach this is to keep all your information and structuring in the HTML file, and use CSS for all styling. Personally, for me, that's an easier way of thinking about how to make it all work well together.

  Here's a way to get the strike-through with CSS (using your HTML):

      del {
          text-decoration: line-through;
      }
  

  Have fun! 😁

  Marked as helpful

  0

  ---

  

  bundasse•100

  @bundassePosted almost 2 years ago

  @jefflangtech Thanks for your comment! I'll upgrade my codes with your advice!😊

  0
• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  • The text-decoration: none property in the * { } selector is removing the default underline style of the <del> element.

  • Avoid using uppercase text in your HTML because screen readers will read it letter by letter. You can use the text-transform property to transform the text to uppercase in CSS.

  • The product image is not a decoration. You must not use the background-image property to add the product image. Instead, use the <picture> and img tags to add the image. Use the background-image property only for decorative images that do not add any information to the page.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  0

  ---

  

  bundasse•100

  @bundassePosted almost 2 years ago

  @MelvinAguilar Oh my god, I totally forget what I wrote in *{} selector! Thank you very much for your feedback, I'll keep it in my mind!😊

  0