Product Preview

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey @felipejoazeiro, great job on this project!

  Some suggestions to improve you code:

  • For accessibility purposes, it’s best to use rem/em instead of px for your CSS property values.

  For media queries, I definitely suggest using em for them. By using px your assuming that every users browser (mobile, tablet, laptop/desktop) is using a font size of 16px (this is the default size on browser). Em's will help with users whose default isn't 16px, which can sometimes cause the your content to overflow and negatively affect your layout.

  • When using different sized images for responsiveness, it’s far more efficient to use the <picture> element.

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  https://web.dev/learn/design/picture-element/

  Happy Coding!

  0