Skip to content
Submitted about 2 months ago

Product Preview Solution

#node
P
Marcelo Colodetti Filho•90
@MarceloColodetti
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

In this challenge I learned about the Picture tag, which allows the website to load only the necessary image according to the required resolution. This was also the first challenge that I uploaded the repository to github through the command terminal. In addition, I also used the node cleancss command for the first time.

What challenges did you encounter, and how did you overcome them?

Knowing how to make different images occupy the same place in different situations was a challenge, so I learned about the Picture tag.

What specific areas of your project would you like help with?

I don't know if I'm doing something wrong, if the information provided is incorrect or if it's something with my monitor, but even using all the specifications provided, the typography is never 100% like Figma's design.

Community feedback

  • P
    KonradJam•550
    @KonradJamPosted about 1 month ago

    @MarceloColodetti Very good solution!

    I have a few pieces of advice:

    • The whole component should be wrapped in an <article>, and you could set the attribute role="main" for a proper accessibility report. Also, wrap the text block in a <section>.
    • The name of the perfume should be wrapped in an <h1> with an id.
    • If you have a visible element that describes the component, you should use aria-labelledby, not aria-label, with the id of the <h1>.
    • For better responsive web design (RWD), switch to CSS logical properties.
    • You could convert images to the WebP file format, as it has a smaller size.
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord