Skip to content
Submitted about 2 years ago

Product Preview Projecy - Solution #1

Carlos Eduardo Lima•90
@ocarloslima
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • バレンタイン 😈•64,170
    @VCaramesPosted about 2 years ago

    Hey @UnDev-XI, some suggestions to improve you code:

    • Implement a Mobile First approach 📱 > 🖥

    With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.

    • To give you HTML code structure, you want to set up your code in the following manner (only did parent containers):
       <body>
      <main>
        <article class=“card-container”>
          <picture></picture>
          <div class="card-content">
          </div>
        </article>
      </main>
    </body>

    The Main Element identifies the main content of the document.

    While the Article Element will serve as the card’s container, because the card represents a complete, or self-contained, section of content that is, in principle, independently reusable.

    More info:

    https://web.dev/learn/html/headings-and-sections/

    • The Alt Tag Description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone.

    • This challenges requires the use of two images 🎑 for different breakpoints. The Picture Element will facilitate this.

    Here is an example of how it works: EXAMPLE

    Syntax:

      <picture>
    <source media="(min-width: )" srcset="">
    <img src="" alt="">
  </picture>

    **More Info: **

    https://www.w3schools.com/html/html_images_picture.asp

    https://web.dev/learn/design/picture-element/

    • There is only one heading in this challenge and that is the name of the perfume, “Gabrielle Essence Eau De Parfum”.

    Happy Coding! 👻🎃

    Marked as helpful
    1
    Carlos Eduardo Lima•90
    @ocarloslimaPosted about 2 years ago

    @vcarames Thank you very much!

    I will apply this structure and focus on cell phone screen size in my next codes!

    And thanks for all the tips and links you sent.

    0
  • Akram Adjab•380
    @akramAdjabPosted about 2 years ago

    Hello Carlos, Congrats on completing this challenge

    I checked the html and css files and the code in both of them are great, just a small issue that I noticed

    • Every page must contain one h1 for SEO optimization

    Hope my feedback is helpful 🙌🏻

    Marked as helpful
    1
    Carlos Eduardo Lima•90
    @ocarloslimaPosted about 2 years ago

    @akramAdjab Thank you very much! I followed your advice and changed the <h2> element to <h1>

    It's something I didn't really care about in my codes... well, until now!

    Thank you again!

    1
    Akram Adjab•380
    @akramAdjabPosted about 2 years ago

    @UnDev-XI my pleasure carlos 🙌🏻

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord