Product-preview page using HTML and CSS

Community feedback

• 

  Edwin Ndambiri•70

  @EdwinNdambiriPosted 24 days ago

  Nice

  0
• 

  P

  Ethan John Paguntalan•160

  @dev-ethanjohnPosted 24 days ago

  Hey Leo, I hope you are well.

  Your HTML structure looks good and your code is good enough for semantics. Good way you use main for this. There are things I may recommended you to check out.

  1. You can add article or header on your HTML for better semantics.
  2. Using px on media query is valid, but I recommend you use em for better scaling and for accessibility.
  3. I notice on mobile, the image is not displaying, try to fix your src.
  4. It would be better if you try to emulate as much as possible the design specifics even if these are minor styles like line-spacing, your use of font-family on some components, and among other things.

  Wish you success and more power!

  0

  ---

  

  𝓛𝓮𝓸𝓼𝓶𝓪𝓻𝓽•80

  @leo-smart7Posted 24 days ago

  @dev-ethanjohn thank you very much

  0