@AdrianoEscarabote
Posted
Hi Nilesh Choudhary, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:
I noticed that the main
tag is stretching a lot, to solve apply a max-width
:
main {
max-width: 550px;
}
Consider using rem for font size. If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.
if you want to continue coding with px, you can download a very useful extension in vscode, it converts px to rem! link -> px to rem
To improve the code structure wrap this div:
<div class="attribution">
with the semantic tag footer
The rest is great!
I hope it helps... 👍
Marked as helpful