Product preview / Frontend Mentor challenge using HTML and CSS

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  PiCTURE TAG 📸:

  • Looks like you're currently using media queries for swapping different version of image, So let me introduce the picture element.

  ---

  • The <picture> tag is commonly used for responsive images, where different image sources are provided for different screen sizes and devices, and for art direction, where different images are used for different contexts or layouts.

  ---

  • Example:

  <picture>
  <source media="(max-width: 768px)" srcset="small-image.jpg">
  <source media="(min-width: 769px)" srcset="large-image.jpg">
  <img src="fallback-image.jpg" alt="Example image">
  </picture>
  

  ---

  • In this example, the <picture> tag contains three child elements: two <source> elements and an <img> element. The <source> elements specifies different image sources and the conditions under which they should be used.

  ---

  • Using this approach allows you to provide different images for different screen sizes without relying on CSS, and it also helps to improve page load times by reducing the size of the images that are served to the user

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  1

  ---

  

  cyrus K yegon•60

  @Kincyrus12Posted over 1 year ago

  @0xAbdulKhalid thank you for taking time to view y code ad writing the feedback i appreciate you taking your time for this, this is helpful to me thank you.

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  @Kincyrus12 Glad you found it helpful ! 🤠

  0
• 

  Paweł Pohl•390

  @Pawel1894Posted over 1 year ago

  Hey,

  I would suggest for you to start thinking about every project as it would be a big scalable project. This approach is going to improve your coding skills and make it more readable. s Css selectors like this:

  container p 
  or
  section .picture1 img
  

  are considered really bad practice in most cases and to maintain. Same with classes like .picture1 it does not really say much and isn't reusable. For start look up for some common css naming methodologies like BEM or Cube. Personally I find BEM really great for start and then moving to cube which is more focus on utility classes.

  1

  ---

  

  cyrus K yegon•60

  @Kincyrus12Posted over 1 year ago

  @Pawel1894 thank you so much for taking time to go through my code i appreciate your feedback this just helped me go and learn more about naming classes. Thank you.

  1