Product Preview Component using HTML and CSS

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @Peteksi95, Congratulations on completing this challenge!

  Your solution its almost done and I’ve some tips to help you to improve it:

  1.Fix the alignment. The best way make this alignment is by using FLEXBOX. The first step, is to add min-height: 100vh to make the body height size becomes 100% of the viewport height, this way you make sure the container will be aligned vertically since the body will display ever 100% of the screen height. After that add two flex properties to make the alignment display: flex / align-items: center; / justify-content: center;. If you're using the attribution you need to add flex-direction: column to make the attribution stays under the QR Code component. See the code below:

  REMOVE THIS PADDING

  main {
      /* padding-top: 6vh; */
  }
  

  body {
      min-height: 100vh;
      font-family: 'Fraunces', serif;
      font-family: 'Montserrat', sans-serif;
      background-color: hsl(30, 38%, 92%);
      display: flex;
      align-items: center;
      justify-content: center;
      flex-direction: column;
  }
  

  2.Using <picture> you’ve more control over the elements and its better than using the product image as <img> or background-image. Look that for SEO and search engine reasons it isn't a better practice to import this product image with CSS since this will make it harder to the image. You can manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device (phone / computer) Here’s a guide about how to use picture: https://www.w3schools.com/tags/tag_picture.asp

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Petri Saari•120

  @Peteksi95Posted about 2 years ago

  @correlucas Thank you very much! This was very helpful

  1
• 

  Hyron•5,870

  @hyrongennikePosted about 2 years ago

  Hi @Peteksi95,

  Congrats on completing the challenge

  If you want to center the card on the page. You can replace you main rule with the following.

  main {
      display: flex;
      justify-content: center;
      align-items: center;
      min-height: 100vh;
  }
  

  Hope this is helpful

  Marked as helpful

  0

  ---

  

  Petri Saari•120

  @Peteksi95Posted about 2 years ago

  @hyrongennike Thank you very much, i will keep this in mind!

  0

  

  Petri Saari•120

  @Peteksi95Posted about 2 years ago

  @hyrongennike Thank you very much, i will keep this in mind!

  0