Product Preview Component pages

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 7 months ago

  Hello @ajibona!

  Your project looks great!

  I have a suggestion about your code that might interest you:

  📌 You can use the <picture> tag when you have different versions of the same image.

  Using the <picture> tag will help load the correct image to the user's device, saving bandwidth and improving performance.

  Example:

  <picture>
      <source media="(min-width: 768px)" srcset="{desktop image path here}">
      <img src="{mobile image path here}" alt="{alternative text here}">
  </picture>
  

  I hope this helps!

  Other than that, excellent work!

  Marked as helpful

  1

  ---

  

  Ajibona•210

  @ajibonaPosted 7 months ago

  @danielmrz-dev Thanks so much I appreciate that it’s really help alot

  1
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted 7 months ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have a suggestion regarding your code that I believe will be of great interest to you.

  ---

  PiCTURE TAG 📸:

  • Looks like you're currently using media queries for swapping different version of image,

  <div class="product-banner"></div>
  
  .product-banner {
    background-image: url(images/image-product-mobile.jpg);
    background-position: center;
    background-size: cover;
  }
  
  @media only screen and (min-width: 768px) {
    .product-banner {
      background-position: center;
      background-image: url(images/image-product-desktop.jpg);
      background-size: cover;
    }
  }
  

  • So let me introduce the picture element. It's commonly used for responsive images, where different image sources are provided for different screen sizes and devices, and for art direction, where different images are used for different contexts or layouts.

  ---

  • Example:

  <picture>
    <source media="(max-width: 768px)" srcset="small-image.jpg">
    <source media="(min-width: 769px)" srcset="large-image.jpg">
    <img src="fallback-image.jpg" alt="Example image">
  </picture>
  

  ---

  • In this example, the <picture> tag contains three child elements: two <source> elements and an <img> element. The <source> elements specifies different image sources and the conditions under which they should be used.

  ---

  • Using this approach allows you to provide different images for different screen sizes without relying on CSS, and it also helps to improve page load times by reducing the size of the images that are served to the user

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Ajibona•210

  @ajibonaPosted 7 months ago

  @0xabdulkhalid I'm so happy with that thanks I just learned new way of doing it much better from you now thanks for your feedbacks I love it

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted 7 months ago

  You're welcome @ajibona !

  0