Design comparison
Solution retrospective
Any feedback would be greatly appreciated π
Community feedback
- @VCaramesPosted about 2 years ago
Hey @paulhjin, some suggestions to improve you code:
- This challenges requires the use of two images π for different breakpoints. The Picture Element will facilitate this.
Here is an example of how it works: EXAMPLE
Syntax:
<picture> <source media="(min-width: )" srcset=""> <img src="" alt=""> </picture>
More Info:
https://www.w3schools.com/html/html_images_picture.asp
https://web.dev/learn/design/picture-element/
-
There is only one heading in this challenge and that is the name of the perfume, βGabrielle Essence Eau De Parfumβ.
-
The old price π· is not being announced properly to screen readers. You want to wrap it in a Del Element and include a sr-only text explaining that this is the old price.
Happy Coding! π»π
1 - @DeolabestPosted about 2 years ago
Hey @paulhjin, Congratulations on completing this challenge!
- Your probably forgot to add this cursor: pointer; to the hover effect.
Keep doing a good job!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord