Product Preview Component

Community feedback

• 

  Adeola Ganiu•1,320

  @DeolabestPosted about 2 years ago

  Hey @godsonCodes, Congratulations on completing this challenge!

  Here is my feedback:

  • It's not a good practice to use px to set font-size. Instead use rem units, they are great since they adapt better to the font-size the user will set in the browser settings. You can convert from px to rem here: https://pixelsconverter.com/px-to-rem.

  • Use <main> instead of a simple <div> to improve the semantics and accessibility on the page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.

  Keep doing a good job!

  Marked as helpful

  2

  ---

  

  Olayinka Oluwafemi•60

  @godsonCodesPosted about 2 years ago

  @Deolabest Thanks for your feedback. It is helpful.

  0
• 

  Mohamed Mostafa Khudari•660

  @mohamedmostafakhudariPosted about 2 years ago

  I recommend using img element displayed as a block rather than background image in this case so that you have more control over it when using flexbox to achieve the desired responsive layout.

  Also you can add transition property to the button to add a touch of smoothness when you hover over it.

  Overall great job, learning never stops and I wish you good luck in your journey.

  0

  ---

  

  Olayinka Oluwafemi•60

  @godsonCodesPosted about 2 years ago

  @cheng-moo Thanks for your inputs. Will do well to adopt them in subsequent designs

  1