Design comparison
Solution retrospective
Hello.
I just completed the product preview card component. Please review my solution and give your comments with respect to the following:
- height of the container component?
- use of font styles and colors?
- responsiveness of the submission?
Community feedback
- @DeolabestPosted about 2 years ago
Hey @godsonCodes, Congratulations on completing this challenge!
Here is my feedback:
-
It's not a good practice to use px to set font-size. Instead use rem units, they are great since they adapt better to the font-size the user will set in the browser settings. You can convert from px to rem here:
https://pixelsconverter.com/px-to-rem.
-
Use <main> instead of a simple <div> to improve the semantics and accessibility on the page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.
Keep doing a good job!
Marked as helpful2@godsonCodesPosted about 2 years ago@Deolabest Thanks for your feedback. It is helpful.
0 -
- @mohamedmostafakhudariPosted about 2 years ago
I recommend using img element displayed as a block rather than background image in this case so that you have more control over it when using flexbox to achieve the desired responsive layout.
Also you can add transition property to the button to add a touch of smoothness when you hover over it.
Overall great job, learning never stops and I wish you good luck in your journey.
0@godsonCodesPosted about 2 years ago@cheng-moo Thanks for your inputs. Will do well to adopt them in subsequent designs
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord