Design comparison
Solution retrospective
While I could align everything inside the flexbox, the main trouble was aligning the whole box to the center of the page vertically. Also I couldn't justify-content: center; otherwise the background would be all over the place hence I had to specify width and set margin to auto
Community feedback
- @correlucasPosted about 2 years ago
👾Hello R. Raghav, Congratulations on completing this challenge!
Amazing solution! I’ve just opened the solution’s live site and I liked the job you’ve done a lot. I’ve some suggestions for you:
You did a good work putting everything together in this challenge, something you can do to improve the image that needs to change between mobile and desktop is to use
<picture>
instead of<img>
wrapped in a div. Look that for SEO and search engine reasons isn’t a better practice import this product image with CSS since this will make harder to the image be found. You can manage both images inside the<picture>
tag and use the html to code to set when the images should change setting the devicemax-width
depending of the device (phone / computer) Here’s a guide about how to usepicture
:https://www.w3schools.com/tags/tag_picture.asp
✌️ I hope this helps you and happy coding!
Marked as helpful1 - @Ri-RaghavPosted about 2 years ago
Huh, the solution looks different on my device than here https://i.imgur.com/ITa1EMH.png
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord