Product Preview Cards with Intrinsic Sizing

Community feedback

• 

  Tushar Biswas•4,080

  @itushPosted over 1 year ago

  Congratulations on completing the challenge! 🎉

  The desktop-view of your solution looks nice. But on mobile screens you may want to just fix two things to make it look even nicer.

  -The footer flies up approximately in the middle.

  -The main element does not have some top and bottom margin.

  Feel free to checkout my project code and live site.

  I always try to use relative CSS units because they scale better between different rendering mediums. And use absolute CSS units unless it's absolutely necessary. I haven’t faced any trouble with viewport units, so far so good 🤞😁

  You may checkout my article on 12 Important CSS topics and find some tips on developing more responsive website

  Once again you have done a wonderful job.

  And I look forward to see cool projects from you in the future🚀

  Keep at it...💻 Happy hacking!

  Marked as helpful

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  PiCTURE TAG 📸:

  • Looks like you're currently using media queries for swapping different version of image, So let me introduce the picture element.

  ---

  • The <picture> tag is commonly used for responsive images, where different image sources are provided for different screen sizes and devices, and for art direction, where different images are used for different contexts or layouts.

  ---

  • Example:

  <picture>
  <source media="(max-width: 768px)" srcset="small-image.jpg">
  <source media="(min-width: 769px)" srcset="large-image.jpg">
  <img src="fallback-image.jpg" alt="Example image">
  </picture>
  

  ---

  • In this example, the <picture> tag contains three child elements: two <source> elements and an <img> element. The <source> elements specifies different image sources and the conditions under which they should be used.

  ---

  • Using this approach allows you to provide different images for different screen sizes without relying on CSS, and it also helps to improve page load times by reducing the size of the images that are served to the user

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  2