Design comparison
Solution retrospective
what would i do next time is to ensure to apply KISS principle (Keep It Simple Stupid) + i would look for different approaches to minimize the css
What challenges did you encounter, and how did you overcome them?I watched kevin powell video he says that on front end mentor do something extra something that is cool so I implemented the svg that is under the type of the product plus switching products functionality. the layout is super simple i finished it in less than a day but the responsive part was a bit challenging
What specific areas of your project would you like help with?i know there is problems with the CSS but i'm asking you to review the code and tell me every single small detail that i made badly and how i can improve it , what i need to learn more
Community feedback
- @KapteynUniversePosted about 1 month ago
Hey, nice job. Love the additions.
I see you are toggling the display of the 2 product. If there are more than 2 product like an array of products or json file, i think it would be inefficient. So instead of changing the display, you can change the innerHTML and img. When you click right left buttons they would simply change a number variable, like x++, x-- and according to that number product will change. Also resizing the vector under the h3 to same width as h3 could be better maybe (It looks nice under perfume but a bit large under watch, not completely sure, might be better or worse :D).
Also, i think you can use article tag for the product div. The article tag specifies independent, self-contained content. An article should make sense on its own and it should be possible to distribute it independently from the rest of the site.
Besides going from h3 to h2, everything looks good.
Marked as helpful1@YazanJbaraPosted about 1 month ago@KapteynUniverse Thank you so much for the review and your comment , Yes you are absolutely right , i will try to improve this project more and more and i might implement more products so i can practice what you have said
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord