@vishalbrdr
Posted
set img height to 100%. set product-info height same as the product-image height. or don't specify a height for any, just set the height of the container and let flex-box take care of that.
Marked as helpful
Any thoughts? Where did I go wrong? What can I improve?
@vishalbrdr
Posted
set img height to 100%. set product-info height same as the product-image height. or don't specify a height for any, just set the height of the container and let flex-box take care of that.
Marked as helpful
@correlucas
Posted
๐พHello Adriel, congratulations for your solution!
For some reason your live site isn't available check if you've added the right link in the solutions panel and update it.
I've checked your code repository and I've some tips for your:
1.You've used main
to wrap the container and thats good, you can also use <section>
for each column instead of div for better semantic.
2.To wrap both image desktop and mobile with a single element, you can use <picture>
this way you've all control over two images with a single css selector.
3.You've used h4
for the overtext
perfum, this case is better and h2 heading.
Hope it helps and happy coding!
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord