Skip to content
Submitted 4 months ago

Product Preview Card with Responsive Layout

Liam•360
@asmthli
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

This was my first project with a responsive layout. I am happy about learning to use picture and multiple image sources in conjunction with changing layouts.

Next time, I would like to be more sure about the dynamic spacing and text sizes to use.

What challenges did you encounter, and how did you overcome them?

At first I was attempting to apply an image with a source set to change between completely different images given different image sizes. I discovered that the more explicit way of defining breakpoints using pictures better suited this scenario.

What specific areas of your project would you like help with?

I am still unsure of the best way to make text size dynamic. I have thought about using clamp along with view height units for the font size. Would it be best to set the root element font size in this way and then use rem units everywhere?

Thanks

Community feedback

  • Ridwan Hasan•400
    @Ridwan10000Posted 4 months ago

    @lazmth Congratulations on completing the project. You are missing the '<main>' tag. Try to add a max-width property to the container. You used <h3> tag for the perfume text and then used <h1> tag. Generally the ideal usage of heading is like this: you should use one heading tag in a single page once. You should not use a lower order heading before using a higher order heading. Meaning You can not use <h2> to <h6> until and unless you use <h1>. But using otherwise won't affect the look of your page. So instead of <h3> tag try using <p> tag instead.

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord