Product Preview card with HTML, CSS only

Community feedback

• 

  P

  Ralph Virtucio•650

  @ralphvirtucioPosted 6 months ago

  Hi Duy Anh Le, Good job on doing this challenge 🙌🙌🙌

  These are my suggestions to your project:

  • I'd like to suggest, creating a README.md for your project. Even though this is a small project writing README on every project will set your awareness as a developer if the project has a README file. This is important because README communicate important information about a project. Check out this article to learn more about README Check out this article to learn the benefits of writing a good README

  • Try also refactoring your HTML code to semantic HTML. Writing Semantic HTML will improve your websites Accessibility, SEO, Readability Check out this article to learn Semantic HTML and it's importance for accessibility

  • It is also not a good practice to have two <h1></h1> tag element in your code. I'd suggest to update <h1></h1> tag element of the discount price to <p></p> tag element, you can create a label for both prices and then set the class of the labels to visually-hidden this will hide the labels on the UI but when a screen reader reads your this website it will mention the price labels, Here is a sample code

  <div class="product-price">
        <div class="product-price__discount-container">
             <span class="visually-hidden">Discounted Price</span>
              <p class="product-price__discounted">
                  $149.99
               </p>
           </div>
          <div class="product-price__original-container">
             <span class="visually-hidden">Original Price</span>
              <p class="product-price__original
               price">
                  $169.99
              </p>
         </div>
  </div>
  

  If you want to learn more about visually hidden, try checking out this article

  • Try also setting a reset for your CSS this will remove inconsistent margins, paddings, line-heights and other attributes that can cause your web pages to look differently across various browsers Check out this article if you want to learn more about CSS reset

  • If you want to center your card, You can set a min-height property to your body selector with a 100vh value and set a display property with a value of flex then center everything out. I'd suggest resetting your CSS first before doing this.

  I like the card-links to your different challenges ! !

  CODE UP 🧑‍💻🧑‍💻!*

  Marked as helpful

  1

  ---

  

  Duy Anh Le•120

  @leanhduyPosted 6 months ago

  Hey Ralph,

  Thanks so much for the detailed review, feedbacks, and related reading materials. It helps me learn a lot!

  0