Design comparison
SolutionDesign
Community feedback
- @romanhordiienko131Posted 22 days ago
You could use article as a contianer tag instead of div for better semantics. There is no need to wrap button tag in p tag (index.html line 50). There is some mismatches between design and your solution like letter spacing on "PERFUME" text and button size. On small screens button text overflows icon.
0 - @gustavo2023Posted about 1 month ago
Hi! Congratulations on completing this challenge
Here are a couple of suggestions you could take:
- Try to minimize the use of heavy selectors and consider using shorthand properties where applicable. Try to give a class directly to any element you want to style.
- Ensure consistent indentation and formatting for better readability. This will help in maintainability and readability of your code, which in return will make it easier to work with and improve in the future.
- You should use a modern CSS Reset at the start of the project. This will help in having a consistent base for styling. I have been using this one Modern CSS Reset.
Keep up the good work!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord