Product preview card with basics

Community feedback

• 

  Hikmah•1,070

  @HikmahxPosted over 1 year ago

  Hi @CriKno. Great work! I have some feedbacks that may help improve this project:

  • For the card, instead of setting the width to 336px and then 579px on tablet, I think it is better to replace it with max width and set the width to 100%:

  .card {
      width: 100%;
      max-width: 336px;
  }
  
  @media (min-width: 640px){
      .card {
          max-width: 579px;
      }
  }
  

  This is will make the card more responsive. You may add a little padding to the main tag to give some spacing at the side of the card:

  main {
      padding: 16px;
  }
  

  I hope this helps

  Marked as helpful

  1

  ---

  

  CRKNO•50

  @CriKnoPosted over 1 year ago

  @Hikmahx Hello! thaks for take a moment to check my code. I tried change the width for max-width and it's work. I think maybe i should put a min-width so that the card is not deformed so much. I'm rigth? (sorry for my english, I am lerning). And again, than you for your feedback!

  0

  

  Hikmah•1,070

  @HikmahxPosted over 1 year ago

  @CriKno Sure! if that makes the code better

  1