Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product Preview Card using SASS

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


This is my second challenge accomplishment. Please feel free to give feedback. It will help to my coding development. Thank you!

Community feedback

@arberlisaj

Posted

Hi fellow developer , first I would like to congratulate you on completing the "Product Preview Card" challenge and I might have a couple of suggestions regarding yuor awesome solution

  • You want to use as much semantinc html as possible for better seo purpose for instance <div class="container"> could've been <section class="container"> you want to use other tags too like aside , footer , article etc.
  • The designe Folder on github is uneccesary you want to delete it because it just takes some extra space

All in all great solution and SCSS use keep up the good work ! Happy Coding :)

Marked as helpful

1

@jbuast

Posted

@arberLisaj Thank you so much! This is noted! In my next project, I will try to use more semantic tags. Hoping to see you feedback again in the near future!

1

@arberlisaj

Posted

@jbuast Im dropping a follow cus ur so kind :)

1

@arberlisaj

Posted

@jbuast on github too ?

1

@jbuast

Posted

@arberLisaj Okay! I would love to. Hope to learn more from you!

1

@0xabdulkhaliq

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

PiCTURE TAG 📸:

  • Looks like you're currently using media queries for swapping different version of image, So let me introduce the picture element.
  • The <picture> tag is commonly used for responsive images, where different image sources are provided for different screen sizes and devices, and for art direction, where different images are used for different contexts or layouts.
  • Example:
<picture>
<source media="(max-width: 768px)" srcset="small-image.jpg">
<source media="(min-width: 769px)" srcset="large-image.jpg">
<img src="fallback-image.jpg" alt="Example image">
</picture>
  • In this example, the <picture> tag contains three child elements: two <source> elements and an <img> element. The <source> elements specifies different image sources and the conditions under which they should be used.
  • Using this approach allows you to provide different images for different screen sizes without relying on CSS, and it also helps to improve page load times by reducing the size of the images that are served to the user
  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

0

@jbuast

Posted

@0xAbdulKhalid Thank you so much! This is new knowledge for me. I will put this in use. Hope to see your feedback in my future projects. Again, Thank you so much for giving a time to check my project!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord