product preview card using responsive images

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 6 months ago

  Hello there!

  Congrats on completing the challenge! ✅

  Your solution looks great!

  I have a suggestion for improvement:

  📌 Think about using <main> to wrap your main content instead of <div>.

  Imagine <div> and <span> in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.

  This change might not have impact on how your page looks, but it'll make your HTML code clearer and help with SEO and accessibility.

  Hope that's helpful!

  Keep up the great work!

  Marked as helpful

  1
• 

  P

  Koda👹•3,830

  @kodan96Posted 6 months ago

  hi there! 👋🏻

  • you applied padding to your .container element, that's why your img won't take up the whole area. just remove the padding from .container, and apply padding to the .information element, or you can apply negative margin to the img, but it's better if you do the first option.

  • additional tip: don't use fixed width and height, especially not for container elements that has text inside of them.

  Hope this helped 🙏

  Good luck and happy coding! 💪

  Marked as helpful

  1