Product Preview Card using React

Community feedback

• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  HTML 🏷️:

  • This solution generates accessibility error reports due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the element <div id="root"> the with semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  HEADINGS ⚠️:

  ---

  • And, This solution generates accessibility error reports due to lack of level-one heading <h1>

  ---

  • Every site must want at least one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Franklin David Macias Avellan•230

  @Davic15Posted over 1 year ago

  @0xAbdulKhalid Thank you so much.

  I was wondering where those messages came from, but now I have everything clear and without errors or warnings.

  Thanks again.

  0
• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  Congrats on completing the challenge successfully! Your submission looks great on desktop size. However you can tweak the responsiveness for changing the flex-direction to column in mobile view. You can use media queries for that. For example:

  @media (max-width: 500px) { .main-container { flex-direction: column; ...rest of your code} }

  Also don't change the children elements that are set to width: 50% for mobile so that become 100%.

  Additionally, you can add a button:hover { background-color: different-background-color-here; } and cursor:pointer; to indicate users its clickable.

  Hope you found this helpful!

  Marked as helpful

  0

  ---

  

  Franklin David Macias Avellan•230

  @Davic15Posted over 1 year ago

  @visualdenniss Hello, thanks for your feedback.

  I already made the necessary modifications for the new breakpoint, and for the button hover.

  I thought that the challenge should be with the indicated breakpoints, but I see that I am free to use more.

  Thanks again.

  1

  

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  @Davic15 Glad to hear it was helpful. Yea you don't have to limit yourself to 375px, 768px breakpoints etc. you can just add as many as you need. Challenges show us a direction, but you can always go beyond that :) Good luck on upcoming challenges!

  0