Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product preview card using HTML and Flexbox

Christinaβ€’ 90

@teenabobeena

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


  1. How can I get rid of the vertical space between the image and the info?
  2. How can I put space between the shopping cart icon and the add to cart?
  3. Why didn't border radius work on the left side of the image?
  4. Why didn't font weight 700 make the p text bold?

Thank you for your time and feedback!

Community feedback

Abdul Khaliq πŸš€β€’ 72,660

@0xabdulkhaliq

Posted

Hello there πŸ‘‹. Congratulations on successfully completing the challenge! πŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

PiCTURE TAG πŸ“Έ:

  • Looks like you're currently using single image for both Desktop & Mobile devices, but we want to swap images according to their screen sizes. Luckily there's a native html element which may help us to achieve this method without need of css
  • So let me introduce the picture element.
  • The <picture> tag is commonly used for responsive images, where different image sources are provided for different screen sizes and devices, and for art direction, where different images are used for different contexts or layouts.
  • Example:
<picture>
<source media="(max-width: 768px)" srcset="small-image.jpg">
<source media="(min-width: 769px)" srcset="large-image.jpg">
<img src="fallback-image.jpg" alt="Example image">
</picture>
  • In this example, the <picture> tag contains three child elements: two <source> elements and an <img> element. The <source> elements specifies different image sources and the conditions under which they should be used.
  • Using this approach allows you to provide different images for different screen sizes without relying on CSS, and it also helps to improve page load times by reducing the size of the images that are served to the user
  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

.

I hope you find this helpful πŸ˜„ Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

1

Christinaβ€’ 90

@teenabobeena

Posted

@0xAbdulKhalid Thanks a lot for your feedback and for introducing me to the <picture> element. This will be very helpful going forward making responsive pages.

0

Account Deleted

Hello CoderπŸ™‚

your solution is great πŸŽ‰

But you used the wrong method to switch images and there are some better ways are available to handle the image switch problem

You can try <picture> tag to switch image

Picture tag :

<picture>

<source media="(min-width: 597px)"
srcset="./images/image-product-desktop.jpg ">


<source media="(min-width: 0px)" 
srcset=" ./images/image-product-mobile.jpg">

<img src="./images/image-product-mobile.jpg" alt="Product_image">

</picture>

And I think you have a lot of doubt related to your solution that's why I recommend you to check out my solution✨ that will definitely going to help you πŸ‘€

I hope that will be helpful for you✌️

Marked as helpful

0

Christinaβ€’ 90

@teenabobeena

Posted

@MrSandipSharma you were right. I had a lot of doubt! Thank you for the feedback and for showing me the <picture> tag to optimize images going forward.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord