Design comparison
Solution retrospective
Photo responsiveness styles was a challenge, please let me know if there is anyway i can improve my code
Thank you
Community feedback
- @DeolabestPosted about 2 years ago
Hey @, Congratulations on completing this challenge!
Here is my feedback:
I'll suggest you add margin to the top of the discount to match the project's task.
.product-wrapper .product-info .price span { color: var(--dark-grayish-blue); font-size: 1rem; text-decoration: line-through; vertical-align: super; margin-top: 12px; }
Keep doing a good job!
Marked as helpful1 - @im-abhijitPosted about 2 years ago
hi @@AhmedLebda, congrats on completing this one
test your code on width less than 500px , what is happening is your image height is not matching the height of your description box which is looking bad
else everything is looking pretty
you can have a look at my soln to check how i did https://github.com/im-abhijit/product-preview-card-component
Marked as helpful1@AhmedLebdaPosted about 2 years ago@im-abhijit Thank you very much for your feedback, Adjusting the picture was quite a challenge for me I will try to improve it
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord