Product Preview Card using HTML and CSS

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted about 2 years ago

  Hey @blurridge, adding to what was said above/below:

  • Implement a Mobile First approach .📱

  With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start buildingyour website/content for smaller screen first and then adjust your content for larger screens.

  • The Alt Tag Description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone.

  • The name of the perfume, “Gabrielle Essence Eau De Parfum” is the most important content in your card. So it has to be wrapped in a <h1> Heading. If this was a larger challenge with more card in the same page, then an <h2> or <h3> heading would be the better choice.

  • The old price is not being announced properly to screen readers. You want to wrap it in a Del Element and include a sr-only text explaining that this is the old price.

  • The "Button" is created with the wrong elements. It needs to be Button Element so that when the users clicks on it (with the help of JS), the product gets added to the cart.

  Happy Coding! 👻🎃

  Marked as helpful

  0

  ---

  

  Zach Riane Machacon•40

  @blurridgePosted about 2 years ago

  @vcarames Thanks for being detailed about everything! I recently got back to HTML and CSS and I forgot about some elements. Del really looks like the better option for having strikethrough text and also my mistake for using div over button.

  0
• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello @blurridge, Congratulations on completing this challenge!

  Your solution its almost done and I’ve some tips to help you to improve it:

  Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

  Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

  See the example below:

  <picture>
    <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
    <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
  </picture>
  

  👨‍💻Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/product-preview-card-vanilla-css-and-custom-hover-state-on-hero-85A1JsueD1

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Zach Riane Machacon•40

  @blurridgePosted about 2 years ago

  @correlucas Thank you so much for this! Always have been confused when to use img / picture / div.

  0

  

  Zach Riane Machacon•40

  @blurridgePosted about 2 years ago

  @correlucas When do you think should img be preferred over picture? Or is it always picture over img?

  1

  

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  @blurridge When you've a design that changes to mobile/desktop and the image changes the size. If the image keeps the same size between devices you can use a simple <img>

  0