Design comparison
Solution retrospective
In my second solution i used CSSgrid and the root pseudo-class for the firts time. Any feedback is appreciate.
Community feedback
- @Mr-jawPosted almost 2 years ago
Hello there 👋
Congratulation on completing the challenge
HTML 📄
-
avoid using
<span>
tag to display text. Since the<span>
tag is mostly used to group inline elements. rather you could have used<h1>
tag instead of<span class="category">PERFUME</span>
and<h2>
tag instead<h1 class="product-title">Gabrielle Essence Eau De Parfum</h1>
to increase accessibility. -
rather than using
<p>
tag for<p class="special-price">$149.99</p>
and<p class="regular-price">$169.99</p>
. you may consider using<em>
or<strong>
or<small>
tags for short text, Since<p>
is used to descriptive text
These are issues related with lack of Semantic HTML and accessibility
I hope this was helpful 😊
KEEP GRINDING
Marked as helpful1@AEPEX25Posted almost 2 years ago@Mr-jaw Thanks for the feedback, I’ll take note about those suggestions.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord