Product Preview Card Using CSS Grid and Mobile-First Workflow

Community feedback

• 

  Fatlind Shehu•2,230

  @fatlindshehuPosted over 2 years ago

  Hi @cgrkzlkn, Nice work out there, your solution looks great, and your code looks clean, there are some improvements I would suggest:

  • You don't need a border-radius on the image instead you can set overflow: hidden; to the body and it will automatically make the image borders become rounded.
  • Try to avoid using multiple units in the same project like rem em and px instead determine which one are you going to use and stick with that, I would avoid using px because it makes it harder when working with different screen sizes ( I prefer using rem)
  • rem and em have a different font base so they can be messy in bigger projects, if you're interested in reading more about units check this link

  Good luck on your future projects...

  Marked as helpful

  1

  ---

  

  Cagri Kizilkan•210

  @cgrkzlknPosted over 2 years ago

  @fatlindshehu Thanks for your suggestions!

  0