Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product Preview Card Using CSS Grid and Mobile-First Workflow

@cgrkzlkn

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I am open to any ideas to improve my code.

Community feedback

Fatlind Shehu 2,230

@fatlindshehu

Posted

Hi @cgrkzlkn, Nice work out there, your solution looks great, and your code looks clean, there are some improvements I would suggest:

  • You don't need a border-radius on the image instead you can set overflow: hidden; to the body and it will automatically make the image borders become rounded.
  • Try to avoid using multiple units in the same project like rem em and px instead determine which one are you going to use and stick with that, I would avoid using px because it makes it harder when working with different screen sizes ( I prefer using rem)
  • rem and em have a different font base so they can be messy in bigger projects, if you're interested in reading more about units check this link

Good luck on your future projects...

Marked as helpful

1

@cgrkzlkn

Posted

@fatlindshehu Thanks for your suggestions!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord