Fatlind Shehu• 2,230
@fatlindshehu
Posted
Hi @cgrkzlkn, Nice work out there, your solution looks great, and your code looks clean, there are some improvements I would suggest:
- You don't need a
border-radius
on the image instead you can setoverflow: hidden;
to the body and it will automatically make the image borders become rounded. - Try to avoid using multiple units in the same project like
rem
em
andpx
instead determine which one are you going to use and stick with that, I would avoid using px because it makes it harder when working with different screen sizes ( I prefer using rem) rem
andem
have a different font base so they can be messy in bigger projects, if you're interested in reading more about units check this link
Good luck on your future projects...
Marked as helpful
1
Cagri Kizilkan• 210
@cgrkzlkn
Posted
@fatlindshehu Thanks for your suggestions!
0