Design comparison
Solution retrospective
-
I felt difficulty while comparing this project with code and Design
I am really happy with this frontend mentor it thought me many things in this process. now I can believe that I can do any project.
Thank You.
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the
main
element.
More Info:📚
- The image’s
alt tag
description needs to be improved upon to better describe what it is. You will want to assume that you are describing the image to a someone.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- This component requires the use of two images 🎑 at different breakpoints. The
picture
element will facilitate this.
Here is an example of how it works: EXAMPLE
Syntax:
<picture> <source media="(min-width: )" srcset=""> <img src="" alt=""> </picture>
More Info:📚
https://www.w3schools.com/html/html_images_picture.asp
- The only heading in this component, is the name of the perfume; “Gabrielle Essence Eau De Parfum” . The rest of the text should be wrapped in a
paragraph
element.
- Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a
del
element and inside it you will add aspan
element with ansr-only class
that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful0@dheeraj-90040Posted almost 2 years ago@vcarames Thank you for helping me. I will ratify the errors and mistakes that I have made in this. this is my first project and I am in the learning stage. by the way nice meeting you . can you be my friend for any doubts and guidance? my Instagram id is dheeraj_aa can I let know yours plz I think you are an experienced programmer.
Thank you
0@VCaramesPosted almost 2 years ago@dheeraj-90040
I am glad that I was able to help out!
Unfortunately, I don't use social media. But you can alway reach me out through here of GitHub.
I still have a lot to learn.
Keep it up!
Marked as helpful1 - To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord