Product preview card using CSS and HTML

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • let me explain, How you can easily center the component.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component

  body {
      min-height: 100vh;
      display: grid;
      place-items: center;
      margin: 0;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  .body {
    margin: auto;
    margin-top: 200px;
  }
  

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Gems-coder•120

  @Gems-coderPosted over 1 year ago

  @0xAbdulKhalid thanks for your review i must say your review was very helpful and i learned a great deal from it as it is teachable and engaging. i look forward to more of your feedbacks.

  0
• 

  Munsif Ali•200

  @Munsif-AliPosted over 1 year ago

  there is a little gap in the main card and the image borders at the bottom give the image height 100% to take the full height on the parent like this:

  img{
  height: 100%;
  }
  

  and for image use picture tag in html

   <picture>
    <source media="(min-width:650px)" srcset="img_pink_flowers.jpg">
    <source media="(min-width:465px)" srcset="img_white_flower.jpg">
    <img src="img_orange_flowers.jpg" alt="Flowers" style="width:auto;">
  </picture> 
  

  in that you can specify different images source according to the width you can read more about here about picture tag

  Marked as helpful

  0

  ---

  

  Gems-coder•120

  @Gems-coderPosted over 1 year ago

  @Munsif-Ali thanks for your review. i just tried using the picture tag in my html but am finding hard at the moment nevertheless i will keep on trying till i get it done and i will appreciate if you can please elucidate more on it. thanks for your review as it is teachable and engaging

  0