Design comparison
Solution retrospective
I'm not very confident in the way I added the shopping cart icon, is there any recommended way to add icons?
The icon I added belongs to Material Design, is it ok to use it in this layout?
I tried to use the BEM methodology to name the elements, but when I added the shopping cart icon, the class was already defined, would that be noise? should adjust for the BEM?
I would like feedback on responsiveness adjustments, I just added a screen variation, is it recommended to complement?
This is a simple project, but I'd be happy to get any additional feedback! Thanks!
Community feedback
- @Yehan20Posted about 2 years ago
Hello there, Solution looks neat, Congratulations. You might not need to add fixed widths, it will be kind of trouble when making them responsive, instead you can go with a max-width, which will be easy to play with. Secondly, regarding the image, I would use it as a background image since it will easy to control. That's my preference, really. I don't think you need to give fixed heights really, you can use padding to achieve that. I hope this was helpful, good luck for the other challenges.
Marked as helpful0@guilepereiraPosted about 2 years agoThese tips helps a lot, thanks so much @Yehan20!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord