Product Preview Card UI

Community feedback

• 

  Tamana•210

  @Tamana123-2Posted over 1 year ago

  Hi! Good job for completing the challenge, but remember to start the project from mobile design. First you could get display grid for being more flexible on desktop version as well; you can write all the code needed for mobile version, when it comes for desktop design you could use media quarries and set the (grid-template-columns: 1 fr fr) to make the lay out side by side. I also did the project if you want you can have a look at. Nice time.

  Marked as helpful

  0
• 

  Finney•3,030

  @Finney06Posted over 1 year ago

  Hello there 👋. Good job on completing the challenge !

  Here are some suggestions regarding your code that may be of interest to you.

  HTML 🔤:

  To clear the Accessibility report:

  • Wrap the page's whole main content in the <main> tag.

  • Use an h1 tag for the main text in the design given and always avoid skipping heading levels; Starting with <h1> and working your way down the heading levels (<h2>, <h3>, etc.) helps ensure that your document has a clear and consistent hierarchy.

  • Use HTML5 semantic elements such as <header>, <nav>, <main>, <aside>, and <footer> to define these sections.

  • Use ARIA landmarks such as <header role="banner"> and <footer role="contentinfo"> to provide additional information about the purpose of each section to assistive technologies.

  Here is a web accessibility evaluation tool📕 to check your webpage for any remaining errors or warnings related to landmarks.

  I hope you find it helpful!😏 Above all, the solution you submitted is 👌. 🎉Happy coding!

  Marked as helpful

  0