Design comparison
Community feedback
- @AdrianoEscarabotePosted about 1 month ago
Hi mahdyar, hope you're doing well! I loved how your project turned out, but I’ve got a few suggestions that could be useful:
Consider using
rem
for font sizes. When font sizes are set in absolute units like pixels, users can't adjust the text size based on their preferences. Relative units likerem
adapt to the screen size and user settings, making them more flexible across various devices.If you'd rather keep using
px
, you can download a handy VS Code extension that converts pixels torem
automaticallylink -> px to rem
We have to make sure that all the content is contained in a reference region, designated with HTML5 reference elements.
native HTML5 reference elements:
<body> <header>This is the header</header> <nav>This is the nav</nav> <main>This is the main</main> <footer>This is the footer</footer> </body>
The rest is fantastic.
Hopefully, you'll find it helpful. 👍
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord