Product Preview Card Solution

Community feedback

• 

  Shashikant•430

  @shashikantdev3Posted over 1 year ago

  Hello there 👋. Good job on completing the challenge!

  Here are some suggestions regarding your code that may interest you.

  For Responsiveness

  Your solution for desktop screen size looks excellent, but for Mobile screens, try to add more CSS to your media query. I suggest adding visually-hidden content for the price and oldPrice, so it doesn't generate an accessibility report and is also a best practice for accessibility.

  Below is the link to my solution repo, please feel free to take a look and get the idea of proper restructuring of media queries, accessibility and usage of utility class and be careful when you use GRID and Flex.

  My Solution Repo

  You can see the tutorial, where Kevin explain all these things very clearly, below, is the YouTube link for the tutorial.

  YouTube | Kevin Powell | Taking on a Frontend Mentor challenge | Responsive Product Preview Card Component

  I hope you find it helpful!😏 Above all, the solution you submitted is 👌. 🎉Happy coding!

  0