Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product Preview Card Solution

@StephenStarc

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Please review my code and help me to find mistake in code

Community feedback

@Kulyk-Volodymyr

Posted

Great work!

On mobile horizontal screen footer is on top on main. This can be fixed by removing position: fixed from .attribution. But after that main won't be in the center. You can set some height to footer and the same value to margin-top in main.

Also you can change background-size in body from 100% to cover and add background-position: center.

Marked as helpful

0

@StephenStarc

Posted

@Kulyk-Volodymyr Thanks for the suggestion. I will change it. I have another doubt even though I set min-height to 100vh in body, I still have a scroll option

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord